https://bugzilla.wikimedia.org/show_bug.cgi?id=45802

--- Comment #1 from Krinkle <[email protected]> ---
The commit message should have the following format[1]:

> Subject (MUST be < 62 chars)\n
> \n
> Body

Though it is not documented on the wiki page, the problem is that you were
using Windows-style CR line breaks instead of LF.

Gerrit apparently only looks for LF, not CR. Which I think is fine since it is
our convention not to use CR (When checking the diff in git on the command line
it will warn for CR as well). Be sure to configure your editor to not use CR.

Different layers on git will do it differently. I see that on GitHub it will
separate the subject by either LF or CR. Gerrit does not. You could file an
upstream issue.

https://gerrit.wikimedia.org/r/#/c/52439/2//COMMIT_MSG

[1] https://www.mediawiki.org/wiki/Git/Commit_message_guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to