https://bugzilla.wikimedia.org/show_bug.cgi?id=20077
--- Comment #2 from Dan Nessett <[email protected]> 2009-08-07 22:54:31 UTC --- (In reply to comment #1) > > * MediaWiki_TestCase.php: fixed bug related to a change in the name of the > > global variables $wgDBadminuser (-> $wgDBuser) and $wgDBadminpassword > > (->$wgDBpassword). Also fixed bug that wrote over $wgDBprefix, causing > > creation > > of test tables to fail. Tested code for both MySQL version >= 4.1 and < 4.1 > > (by > > creating temporary debug version of if statement - tests occured using MySQL > > version 5.0.41). > > > > This is incorrect. $wgDBadminuser/$wgDBadminpassword are used for attaining > "administrative" access to the DB. In practice, most scripts don't need this. > Since we're creating temp tables though, it's probably worth using > $wgDBadminuser here, we don't know if $wgDBuser has access to do that. > OK. I will change them back. However, in order to test them I have to create $wgDBadminuser and $wgDBadminpassword for my local test wiki. Any pointers on how to do this? >From your comments on wikitech I just set them in LocalSettings.php - correct? > Moving the tests to a subdirectory would be fine, and pretty trivial as long > as > all referencing paths are updated too. > I will start working on this. > > Also, something I noticed: $PhpUnitDirectory is nasty and should be removed. > A) > PEAR should already be in the include path B) We don't like telling people to > edit any files other than LocalSettings, as changes can get lost on upgrade. > OK. However, on my system I had to define this variable in order to find the files in PHPUnit (e.g., TextUI/Command.php). My system may be a bit unusual since the OS comes with php4 installed. I use MAMP, which comes with php5, but in order to override php4, I had to do a bunch of softlinking and aliasing. I don't know if this is inadequate in order to get PEAR in the include path or something else is wrong, but until I can figure this out, I can't test the elimination of $PhpUnitDirectory. Any suggestions? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
