https://bugzilla.wikimedia.org/show_bug.cgi?id=45751
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from [email protected] --- As there are not too many extension points yet, plugins cannot be hooked in at the relevant places to help with this problem. However, I just tried to apply the patch locally, but it does not apply cleanly any longer. Taking a look nonetheless, I guess there might be a problem with generating the FooterLine. In the patched line 135 in ChangeUtil.java, it seems the FooterLine constructor is missing around the arguments of add. However, that constructor would have package visibility anyways, so we cannot simply call it from within gerrit. We'd have to shoehorn the "subject's tracking id" in a different way. You could rearrange the nested for loops of updateTrackingIds, refactor the inner body into a private method, and use this method to pass the "subject's tracking id". But that's tedious. On top of that I share your fear that hard-coded checking for "(bug ...)" might be too specific to be accepted upstream. However, the upstream bug that Chad gave looks like a perfect match. One can build on that and try to parse a commit's subject for arbitrary tracking id's and shoehorn them in. That should meet our problem, the upstream bug, and it would be general enough to have a chance of being accepted upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
