https://bugzilla.wikimedia.org/show_bug.cgi?id=44161

This, that and the other <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from This, that and the other <[email protected]> ---
This is causing problems for Twinkle on enwiki (which is forced to lightly
screen-scrape the loaded page in order to find out what the user is looking
at).

Either IP::prettifyIP [1] should be used everywhere, or nowhere. According to
[2] this function is only called from one place in the code. 

IMHO it is too difficult to change over to sanitized IP addresses throughout
the entire codebase, so I say we kill prettifyIP (or at least remove its sole
invocation [3]).

[1]
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/IP.php;h=72b9a52c8123d863bdbe44161c9760af778b496e;hb=HEAD#l195
[2]
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git&a=search&h=HEAD&st=grep&s=prettifyIP
[3]
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/Linker.php;h=972adfceabbe818e97d192c142440263a11b6af1;hb=HEAD#l1085

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to