https://bugzilla.wikimedia.org/show_bug.cgi?id=27676
--- Comment #5 from Liangent <[email protected]> --- (In reply to comment #4) > Hmm there's already a FIXME comment there: Nope. It has been changed after I submitted this bug. 155ddf6d (Andrew Garrett 2009-04-24 01:31:17 +0000 2152) function loadDataFromRequest( $request ) { 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2153) if ( $this->mParent->getMethod() == 'post' ) { 15599d3d (awjrichards 2012-05-04 15:09:33 -0700 2154) if ( $request->wasPosted() ) { 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2155) # Checkboxes are just not added to the request arrays 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2156) # so it's perfectly possible for there not to be an en 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2157) return $request->getArray( $this->mName, array() ); 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2158) } else { 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2159) # That's ok, the user has not yet submitted the form, 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2160) return $this->getDefault(); e0a4a54c (Siebrand Mazeland 2010-05-30 12:44:17 +0000 2161) } 155ddf6d (Andrew Garrett 2009-04-24 01:31:17 +0000 2162) } else { 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2163) # This is the impossible case: if we look at $_GET and see no 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2164) # field, is it because the user has not yet submitted the form 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2165) # have submitted it with all the options unchecked? We will ha 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2166) # latter, which basically means that you can't specify 'positi 75c6696a (Siebrand Mazeland 2011-05-17 22:03:20 +0000 2167) # for GET forms. 75c6696a (Siebrand Mazeland 2011-05-17 22:03:20 +0000 2168) # @todo FIXME... 6bedff7a (Happy-melon 2011-03-14 15:50:26 +0000 2169) return $request->getArray( $this->mName, array() ); 155ddf6d (Andrew Garrett 2009-04-24 01:31:17 +0000 2170) } 155ddf6d (Andrew Garrett 2009-04-24 01:31:17 +0000 2171) } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
