https://bugzilla.wikimedia.org/show_bug.cgi?id=20112





--- Comment #4 from Dan Nessett <[email protected]>  2009-08-10 20:12:52 UTC 
---
(In reply to comment #1)
> (In reply to comment #0)
> > Moved up require of LocalSettings.php, because its definitions are now
> > required by Autoloader.php.
> 
> No, that's the opposite, AutoLoader.php is supposed be included before
> LocalSettings.php (as in includes/WebRequest.php).
> 

It appears that includes/WebRequest.php tests for the existence of $IP and if
it is missing defines it (lines 61-63). I'm not sure what is going on here. For
some reason Webstart wants to define $IP independently of its definition in
LocalSettings.php. Maybe there is a good reason for this, but it's kind of
clumsy (not to mention a potential source of bugs, since it means $IP is
defined in two different place).


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to