https://bugzilla.wikimedia.org/show_bug.cgi?id=38783

--- Comment #41 from Gerrit Notification Bot <[email protected]> ---
https://gerrit.wikimedia.org/r/54902 (Gerrit Change
Ia31a747c0d79f460503f66c369a0d1f2b971b692) | Code-Review: Reviewed:-1 Patch Set
7: Code-Review-1

The following comment by Dereckson is important:
https://bugzilla.wikimedia.org/show_bug.cgi?id=38783#c17

*** I hereby withdraw (abandon) that patch set, because it indeed does not work
as intended, Well, it shows a date, but not necessarily the commit date, or
edit date. ***


Dereckson wrote:

As I indicated in the Ib66be27a review in December, I've tested your patch and
it doesn't work as intended.

First, the logs/HEAD file contains other operations than commits. There would
have been a need to filter to only process "commit" lines.

But there is a bigger issue: the patch currently reads the .git/logs/HEAD file.
This won't always contain the information we want. 

It contains the operation you did to the git repository (e.g. clone, checkout). 

It will only contain the date of the last commit when committed locally. [by
Wikinaut]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to