https://bugzilla.wikimedia.org/show_bug.cgi?id=46456
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[Regression] VisualEditor: |[Regression] VisualEditor: |Cancelling error in |Error in load() leaves page |initialisation leaves page |in dimmed state (Uncaught |in dimmed state |TypeError: Cannot call | |method 'removeAllListeners' | |of null) --- Comment #1 from Krinkle <[email protected]> --- Caused by I7769bd5a5b79f1ab36f258ef9f2be583ca503ce6. In the refactoring Trevor moved the initialisation of the DOM element for the save/cancel buttons from the ve.init.mw.ViewPageTarget constructor to ve.init.mw.ViewPageTarget#setupToolbarButtons, which isn't called until after a successful load. So, when #load() is called from #activate() and fails a loadError is emitted. onLoadError then calls #deacativate() which calls #tearDownToolbarButtons() But tearDownToolbarButtons is unable to call this.toolbarCancelButton.removeAllListeners because the button doesn't exist yet because setupToolbarButtons was never called. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
