https://bugzilla.wikimedia.org/show_bug.cgi?id=46452
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Summary|gerrit-wm should always |gerrit-wm shouldn't |relay human approval/submit |suppress review | |notifications for CR+2 --- Comment #1 from Krinkle <[email protected]> --- (In reply to comment #0) > gerrit-wm should always relay human approval/submit/+2/"C: 2", even when > there's "(no comment)" (removed by bug 35427 I believe). Bug 37047, actually. I agree. Suppressing notifications for reviews that didn't include a comment is generally nice to reduce spam. But the CR+2 events should be reported. When we originally disabled reporting of reviews without comment this wasn't a problem because CR+2 would be CR+2 & submit. Nowadays the submissions are done by jenkins-bot and which means the average CR+2 event no longer includes submission, which means it gets caught in the filter from bug 37047. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
