https://bugzilla.wikimedia.org/show_bug.cgi?id=46611
--- Comment #2 from Svemir Brkic <[email protected]> --- This line does not seem right: +if (!isset($wgSphinxSearch_port) and !is_numeric($wgSphinxSearch_port)) { Perhaps it should be: +if (!isset($wgSphinxSearch_port) || !is_numeric($wgSphinxSearch_port)) { But in general I would rather let the local administrator make sure if they are setting the port at all to make it correct. Quietly ignoring a bad setting is usually not a good idea. These may cause notices on stricter configurations: +if (!$wgSphinxSearch_index) { +if (!$wgSphinxSearch_index_list) { Should probably use isset like other suggested changes. Finally, not sure why we would change default for $wgEnableSphinxPrefixSearch. Does that help with compatibility with 1.19 or 1.20 somehow? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
