https://bugzilla.wikimedia.org/show_bug.cgi?id=46635
Brad Jorsch <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Brad Jorsch <[email protected]> --- (In reply to comment #3) > > > Because as long as tests do not work, [1] is blocked. > > > > > > [1] https://gerrit.wikimedia.org/r/#/c/56393/ > > > > I see no unit tests being added in that changeset. > > Well, I updated the change but as you can see their are two issues first > PropertyLibraryTests.lua returns locally with > > Notice: unserialize(): Error at offset 114 of 118 bytes in > C: > \xampp\htdocs\mw\extensions\Scribunto\engines\LuaStandalone\LuaStandaloneEngi > ne.php > on line 384 Lua error: Internal error: Unable to decode message. Backtrace: > #0 I wonder if that's bug 46294. > but the more severe issue is '''Jenkins''' since Scribunto is not a > dependency > "$wgAutoloadClasses['Scribunto_LuaEngineTestBase']" or class_exists() won't > work because Jenkins checks the directory (-- extensions/SemanticMediaWiki) > and > not the "UnitTestsList hook" so doing > > " ... extends Scribunto_LuaEngineTestBase" will fail in Jenkins for > extensions. I tried to ask hashar about this a while ago. Now that we have an actual example of the problem, perhaps he can tell us what to do about this situation. > It is not really a nice design for a test case You're welcome to try to redesign it. Note that all the tests must be run against both engines, the tests should actually run as separate tests and not one test with hundreds of assertions, it should not require every test class to be updated should another engine be added, and it's best not to require a ton of boilerplate to do so. Good luck. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
