https://bugzilla.wikimedia.org/show_bug.cgi?id=46865
Web browser: ---
Bug ID: 46865
Summary: https://fundraising.wikimedia.org has broken layout,
buttons not working and and uncaught javascript
exceptions
Product: Wikimedia
Version: wmf-deployment
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Fundraising: Misc.
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected]
Classification: Unclassified
Mobile Platform: ---
Created attachment 12033
--> https://bugzilla.wikimedia.org/attachment.cgi?id=12033&action=edit
Screenshot of problems.
* Urls in the page are hardcoded http which means in modern browsers those
requests are blocked when the page itself is accessed over HTTPS.
> Use protocol relative urls.
* There are scripts on the page embedded via <script> with no if(window.mw)
guard.
> Use a guard.
> Better yet, put them in a module and load them that way instead of
embedding it (better caching, easier to update)
* There are references to global functions in eval() evaluated event handlers
in html attributes:
<input type="submit" value="Unsubscribe"
onclick="$('#execute').attr('value',1);">
> Bind an event handler from a script instead of from html.
Assuming this has been in place for years, this should never have passed
review.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
