https://bugzilla.wikimedia.org/show_bug.cgi?id=46615

Bartosz Dziewoński <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch-in-gerrit             |
           Priority|High                        |Low
           Assignee|[email protected]         |[email protected].
                   |                            |org
           Severity|major                       |minor

--- Comment #9 from Bartosz Dziewoński <[email protected]> ---
Ughhhh. Sorry for the fail.

Throwing in the constructor will require us to either:
* keep a hard-coded list of allowed collations (bad, see bug 44667
  and bug 46058)
* duplicate the loading logic to check if all will be OK without
  loading (bad for obvious reasons)
* or just actually load the data in it, which seems sane, but I assume
  we're not doing for a reason.

Tim wrote the code - can you explain? I suppose loading all the data
would be slow, but it's not like we're instantiating Collations left
and right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to