https://bugzilla.wikimedia.org/show_bug.cgi?id=40025
--- Comment #6 from Ori Livneh <[email protected]> --- (In reply to comment #5) > So, checklist then: > > For each of the sync scrips, ensure: > > [X] In version control https://gerrit.wikimedia.org/r/#/c/57854/ > [ ] Have checks for SSH_AUTH_SOCK and dsh etc. > (probably best to centralise in a common function) > [ ] Have checks for existence of directory or file > [ ] Lint PHP > [X] Have consistency in parameters to dsh,mwdeploy,rsync > (perhaps centralise in a common function) https://gerrit.wikimedia.org/r/#/c/57890/ > [ ] notify dologmsg > [ ] notify deploy2graphite > > I'm assigning to myself. I'd like to do this clean up once Tim's scap-to-tin > branch[1] is ready and merged. > > > [1] > https://gerrit.wikimedia.org/r/#/q/project:operations/puppet+topic:scap-to- > tin,n,z -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
