https://bugzilla.wikimedia.org/show_bug.cgi?id=7757
Brion Vibber <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #8 from Brion Vibber <[email protected]> 2009-08-19 02:07:58 UTC --- I'm not fond of this syntax or implementation; reverted in r Reverted: r54748 "Making demon happy (adding public/protected to function definitions) and add some comments along the way." r54746 "Update formatting for r54745" r54745 "Added crop support for inline images." Several issues: * Implementation is ImageMagick-specific, no support for GD backend * Specification syntax is pretty ugly and non-obvious imo... [[File:foo.jpg|<width>px|<left>x<top>x<width>x<height]] * Crop syntax seems to be tied to pixels... I _presume_ source pixels? This would break if a file is re-uploaded with a new size. * In general I'm very leery of tacking on more infinite-options-in-infinite-combinations for image rendering; our treatment of resizing already has implications for CPU and disk usage and this just adds another level of arbitrary-rendered horror. ;) I'd much rather we move towards limiting the number of rendered variants we have, not increase them... IMO cropping would be better served with an interface allowing for explicit, visible cropping which creates either a new saved version, or a 'cloned' virtual file which can be referred to by name... and more importantly, uses of it would be trackable so that if crops needs to be updated they can be cleanly. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
