https://bugzilla.wikimedia.org/show_bug.cgi?id=47343
Web browser: ---
Bug ID: 47343
Summary: VisualEditor: Lazy-update SurfaceFragment
Product: VisualEditor
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Technical Debt
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
For performance reasons, we should lazy-update SurfaceFragments rather than
updating them through a transact event handler.
The performance problem occurs when you create a bunch of fragments, then throw
them away. The fragments are never actually destroyed, if only because the
surface still has references to them because of the event binding. The
discarded fragments continue to receive events about transactions and update
themselves in response, but no one is using them any more.
Instead, I propose the following:
* The surface should have an ordered array of [transaction, direction] pairs
that tracks everything that has ever been applied. This is not the same as the
undo/redo stacks: this particular array is append-only
* Every SurfaceFragment has a property indicating which transaction (by index
in the big array) is the last one that it knows about
* SurfaceFragments do not listen for transact events
* Instead, every time getRange() is called, the fragment asks the surface
whether there are new transactions (with indices greater than the stored
index), and if so it translates its range for them
** For this to work, all internal uses of this.range need to be changed to
this.getRange()
This'll make the fragment lazy-update its range, and we won't spend any time
updating fragments that aren't being used.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
