https://bugzilla.wikimedia.org/show_bug.cgi?id=47481
Web browser: ---
Bug ID: 47481
Summary: Jenkins should merge changes even if no jobs are
configured for the repository
Product: Wikimedia
Version: wmf-deployment
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: Unprioritized
Component: Continuous integration
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
Given that:
* We're aiming to reserve 'verified' for automated CI,
* We're aiming for all merges to be done by Jenkins,
..I think we should have Jenkins merge changes for +2'd patches even in
repositories which do not configure any integration jobs. In such cases Jenkins
would simply do a blind merge.
One possible objection to this approach is that it seems wrong to have Jenkins
certify a change without actually checking it in any way. I think this could be
mitigated somewhat by adding a line to the Gerrit review message indicating
this. (It could even have a link to some CI portal on mediawiki.org).
If we want to drive home the thought that 'verified' should not be touched by
human developers, the current approach is counterproductive. If you're used to
Jenkins merging your changes (as I am), then you'll find you tend to +2 a
change and then forget to verify / submit it. If you're used to working on
repositories that don't have CI, then you are probably more likely to forget
that 'verified' is for Jenkins, and try to submit / merge changes yourself.
Either way, it's confusing.
Another viable solution would be to configure Gerrit not to have a 'verified'
step for repositories with no CI jobs. This might actually be a better
solution, since it frees Jenkins from having to do the mindless step of
verifying untested changes.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
