https://bugzilla.wikimedia.org/show_bug.cgi?id=33175

--- Comment #18 from Krinkle <[email protected]> ---
(In reply to comment #12)
> The content direction issues were resolved in Iaf61fb9e8ad0ba
> by copying the dir and lang  attributes from the #mw-content-text
> div to the document.
> 
> The toolbar issues should be reported separately and with greater detail.

Can someone confirm that the edit surface in VisualEditor is now properly using
the directionality of the wiki content language (instead of the user language)?

From what I can see this bug is fixed in that regard by change Iaf61fb9e8ad0ba
indeed.

(In reply to comment #16)
> (In reply to comment #14)
> > Reopening, the issue will still appear when someone visits [[kk:pagename]]
> > with
> > variant=kk-arab set where wikitext is written in kk-latn. (where kk and
> > kk-latn
> > is ltr and kk-arab is rtl).
>
> Yup, that's a bug. We need to use Title::getPageLanguage() instead of looking
> at #mw-content-text (which is controlled by getPageViewLanguage()).
> 
> However, MW core doesn't quite get this right either, see bug 46463.

So there is a case where the #mw-content-text isn't set to the wiki content
language but to the user language, if the content language has a variation?
That sounds like a MediaWiki core bug perhaps. Though we could export
Title::getPageLanguage() in VisualEditor specifically, looks like this should
be fixed in core instead, given that it sounds like the regular view of an
article when reading articles would be broken now as well. And I think the
VisualEditor edit surface should match what the regular page view does.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to