https://bugzilla.wikimedia.org/show_bug.cgi?id=47581

Krinkle <krinklem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|code-update-regression      |
            Summary|[Regression] VisualEditor   |VisualEditor: API
                   |API paction=serialize       |paction=serialize should
                   |returns status "success"    |say so if Parsoid is
                   |when content is false       |unavailable (instead of
                   |                            |status "success" with
                   |                            |missing content)

--- Comment #2 from Krinkle <krinklem...@gmail.com> ---
(In reply to comment #1)
> Related URL: https://gerrit.wikimedia.org/r/60613 (Gerrit Change
> Icdf64a792c13a326f494e051be47f2946928d142)

This fixed the visible problem described below:

(In reply to comment #0)
> as "Loader keeps spinning forever when creating a new page and
> trying to review/save it"

The error is now handled by stopping the spinner (as we always do after an
aborted load) and display the error.

The error message in my case was "No Wikitext content in response from server"
triggered from ve.init.mw.Target.onSerialize's patch where there are no errors
and eventually finds this by type-checking the content property.

Lowering priority. Todo tasks:

* Don't return status "success" if content is missing, but use status "error".

* Make it not just status "error" but actually trigger a proper API
response.error property with a more direct error, namely that the Parsoid
server is unavailable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to