https://bugzilla.wikimedia.org/show_bug.cgi?id=20275


Aryeh Gregor <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |m




--- Comment #2 from Aryeh Gregor <[email protected]>  2009-08-24 
17:42:58 UTC ---
(In reply to comment #0)
> An easy test showing just top of the iceberg:
> * Create a page with a space in title in a namespace that supports subpages
> (e.g. User).
> * Create a subpage for it.
> * Click on former page's move tab. You'll see "This page has no subpages" at
> the bottom of the dialog instead of subpage(s).
> 
> This is because SQLite requires an implicit ESCAPE, for example, if you would
> like to find all values that end with "100_%", you'll have to write something
> like:
> 
> SELECT * FROM table WHERE field LIKE "%100\_\%" ESCAPE '\'
> 
> Therefore, every query that uses LIKE must be appended with ESCAPE for
> databases that require it.

Where does the ESCAPE have to go?  Right after the LIKE or at the end of the
query?  I'd expect this function to be usable even with additional conditions
after it.  Also remember that there might be parentheses and other fun stuff
thrown in; make sure you pay attention to associativity.

I'd call the method like() rather than prepareLike(), and do away with the
extra escapeSyntax() thing -- just roll it into the like() method and have
SQLite override that.  Also, I'm not sure whether it's better to do 'foo' .
$dbr->like( 'bar%' ), or $dbr->like( 'foo', 'bar%' ), or what.  And if the
latter, I'm not sure if 'foo' should be assumed to be a table name or taken
literally.  Do we have any similar constructions currently to compare to?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to