https://bugzilla.wikimedia.org/show_bug.cgi?id=47417

James Forrester <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Data Model                  |JS/General
           Assignee|[email protected]      |[email protected]
            Product|VisualEditor                |Parsoid
            Summary|VisualEditor: Re-used refs  |Parsoid: Re-used refs
                   |wrongly expanded to <ref    |contain unescaped HTML in
                   |name="…" ></span>           |attributes which causes
                   |                            |issues in Firefox

--- Comment #4 from James Forrester <[email protected]> ---
The problem appears to be with the output from Parsoid with regard to <ref>
tags not being escaped.

To give http://parsoid.wmflabs.org/en/Foobar as an example, in Chrome this
looks fine:

<span id="cite_ref-rfc3092-1-0" class="reference" about="#mwt5"
typeof="mw:Object/Ext/Ref" data-parsoid="{&quot;src&quot;:&quot;<ref
name=\&quot;rfc3092\&quot;
/>;&quot;,&quot;tsr&quot;:[416,438],&quot;dsr&quot;:[416,438,null,null]}"><a
href="#cite_note-rfc3092-1" data-parsoid="{}">[1]</a></span>
<meta typeof="mw:Ext/Ref/Marker" about="#mwt5" group="" name="rfc3092"
content="" skiplinkback="0"
data-parsoid="{&quot;tsr&quot;:[416,438],&quot;selfClose&quot;:true,&quot;src&quot;:&quot;&lt;ref
name=\&quot;rfc3092\&quot; /&gt;&quot;,&quot;dsr&quot;:[416,438,22,0]}">


... but in Firefox the browser presumably doesn't like the un-escaped "<ref
name=... />" in the attribute of the <span> and so it does this:

<span id="cite_ref-rfc3092-1-0" class="reference" about="#mwt5"
data-parsoid="{"src":"<ref name=\"rfc3092\"
/>","tsr":[416,438],"dsr":[416,438,null,null]}"
typeof="mw:Object/Ext/Ref"></span>
<meta typeof="mw:Ext/Ref/Marker" about="#mwt5" group="" name="rfc3092"
content="" skiplinkback="0"
data-parsoid="{"tsr":[416,438],"selfClose":true,"src":"<ref name=\"rfc3092\"
/>","dsr":[416,438,22,0]}"></meta>

I.e., closing the <span> early and throwing away the contents. Note that the
following meta is also fragile as it contains unescaped JSON as well.

The result of this is that <ref name="…" /> is wrongly expanded to <ref
name="…" ></span> and so corrupted on save by Firefox users.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to