https://bugzilla.wikimedia.org/show_bug.cgi?id=46585
Matthew Flaschen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #7 from Matthew Flaschen <[email protected]> --- (In reply to comment #5) > Foremost: the point of Notifications is to increase engagement and editing on > WIKIPEDIA. So if identity and context on Wikipedia are compromised for other > projects, it will be a very shortsighted approach to the problem and will > defeat some of our larger purposes. No one is suggesting Wikipedia not be able to show their icon. However, I don't think there's a reason to *only* allow Wikipedia to. And people are already having issues with the default icon currently in use. But any default site icon is probably not going to work for all sites. And it looks like no one has changed wmf-config to put the Wikipedia icon there even on Wikipedia. Hence, reopening. Here's one way to do option 3: 1. Have a variable for the path a 30x30 site icon (like the favicon, but with the right dimensions). 2. Use that vaiable on all sites (including of course the Wikipedias). 3. Use img tags instead of a background-image for the icons (allows changing the URL without needing a new CSS ruleset). This will help make this simpler, and also make it easier for other extensions to extend Echo. See https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/GettingStarted.git;a=blob;f=resources/ext.gettingstarted.echo.css;h=187c55b3a8e7fc354aa8ee5bb2e58eb72c15a53e;hb=refs/heads/master . If it uses an img tag, we can just pass that in. I already played around with it. A float: left and appropriate margin should do the trick. I can help implement this if you want. The only part that requires some care is coordinating deployment of any other extensions to Echo that use their own icon classes (e.g. GettingStarted above). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
