https://bugzilla.wikimedia.org/show_bug.cgi?id=47143
--- Comment #4 from [email protected] --- (In reply to comment #3) > Looked over this, basically the end goal is to not send more than one > notification to a user regarding a specific change. Both of these changes > come > from the same hook which calls EchoHooks::onArticleSaved. > > I'm thinking we can create an empty array, $notified that will contain a list > of user ids that have already been notified regarding this change. First we > do > the revert event, if that fires we add the victim's user id to $notified. > Next > DiscussionParser::generateEventForRevision can run, which will be passed the > list of notified users. This can then check before sending the notification > about an updated talk page we can do !in_array( $user->getID(), > $previouslyNotified ). > > A quick test implementing this seems to work, but I may be missing several > edge > cases that I just dont know about yet. I cant push a fix to gerrit yet > though > as my ssh keys are not yet valid. This may not work when we enable job queue to process notifications. We can't pass $notifiedUser from one job to another -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
