https://bugzilla.wikimedia.org/show_bug.cgi?id=20431

           Summary: PPCustomFrame_DOM not properly constructed
           Product: MediaWiki
           Version: 1.16-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: need-review, patch
          Severity: normal
          Priority: Normal
         Component: General/Unknown
        AssignedTo: [email protected]
        ReportedBy: [email protected]


Created an attachment (id=6501)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6501)
Patch

PPCustomFrame_DOM (phase3/includes/parser/Preprocessor_DOM.php) derives from
PPFrame_DOM, but it is not properly initialized. PPFrame_DOM::expand() uses
$this->title, among other things, which is not set when a PPCustomFrame_DOM is
created. Similar issue exists with PPCustomFrame_Hash.

This makes custom frames almost unusable.

The attached patch fixes this problem, by calling the parent constructors in
order to correctly fill in the members of the base classes.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to