https://bugzilla.wikimedia.org/show_bug.cgi?id=46512

--- Comment #2 from Luis Felipe Schenone <[email protected]> ---
After some idle weeks I return to work, sorry for the delay.
I'm new to Git and Gerrit, I've been looking carefully at this issue but I'm
not sure how to proceed.
The collapsibleNav feature of the Vector extension has elements spread all over
the extension files, and I'm not sure how to bring them to the Vector skin
without generating conflicts later on with the merging of the other features.
For example, the option to disable the collapsibleNav feature is triggered by a
hook, which is a method of the VectorHooks class. This method uses a property
of the class which contains references to other features of the Vector
extension, such as the footerCleanup feature. Should I just remove everything
not related to collapsibleNav from the VectorHooks class, and push the result?
If I do this, then when merging the footerCleanup changes, a conflict may
arise.
Should I push the VectorHooks class more or less as it is, even if it contains
references to other features?
What is the right way to proceed in these cases?
Any help is appreciated, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to