https://bugzilla.wikimedia.org/show_bug.cgi?id=19646
Niklas Laxström <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #18 from Niklas Laxström <[email protected]> 2009-09-03 07:27:25 UTC --- (In reply to comment #13) > Created an attachment (id=6519) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6519) [details] > Additional Messages rqd for img_auth script Is there some reason to use ` instead of " what is used elsewhere in MediaWiki? (In reply to comment #17) > Created an attachment (id=6523) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6523) [details] +if (!wfRunHooks( 'ImgAuthBeforeStream', array( &$title, &$path, &$name, &$result ) ) ) + call_user_func_array('wfForbidden',merge_array(array($result[0],$result[1]),array_slice($result,2))); Maybe a short comment here about the type of $result wouldn't hurt. If this is a new hook, it should be documented in docs/hooks.txt. +'img-auth-accessdenied' => "[[Image Authorization]] Access Denied", Is the link supposed to go somewhere? Documentation is also wikitext. It looks like you did not update maintenance/language/messages.inc, but hey, other developers forget to update it too. I'm happy that you provided message documentation and that you pass around message keys instead of strings. It is a bit more flexible if you ever want to change something, like support magic words in the translations. +'img-auth-nopathinfo' => "Missing PATH_INFO. Your server is not set up to pass this information - may be CGI-based and can't support img_auth. See `Image Authorization` on MediaWiki.", Manual:x on MediaWiki.org? +'img-auth-notindir' => "Requested path not in upload directory.", is not in the upload directory? +'img-auth-badtitle' => "Unable to construct a valid Title from `$1`.", Title with lowercase, users don't need to care if it is Object for us or not. +'img-auth-nologinnWL' => "Not logged in and `$1` not in whitelist.", "You are not logged in ... is not in the whitelist" +'img-auth-nofile' => "`$1` does not exist.", Maybe prefix with File, to give a hint what is expected +'img-auth-isdir' => "`$1` is a directory.", Same here, you could say we except a file, but directory was given. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
