https://bugzilla.wikimedia.org/show_bug.cgi?id=47621

--- Comment #2 from [email protected] ---
That bug slipped through :-/ Sorry.

Those two links do not refer to the same thing:
* https://gerrit.wikimedia.org/r/60705 is tied to a project, a branch,
  and a Change-Id. So we need that number to unabiguously see to
  which project, branch, change-id this change belongs to.
* I3517a9aab8fa8935a86130c4bbdc0ce117f28f02 allows to reference
  changes across branches.

While the first variant gives you an immediate link to the change on
the correct project/branch in Gerrit, 60705 is not stored in git
commit messages. So you cannot grep for it in git log, and it's harder
to see if the patch has been integrated in your branch etc. For those
latter use cases, the Change-Id comes in handy.

By dropping either of those links, we'd fail to give some group the
information they'd need. Hence, I'd rather keep them both.

For abbreviating the Change-Id ... I am not a huge fan of using
trimmed hashes as ids, or references. Especially if they are not real
hashes, but user supplied strings. The proposed I+8 characters format
gives us 10 collisions already, for a single year of using gerrit.
E.g.: "That might be related to I1bbc1ff716" could mean both
* https://gerrit.wikimedia.org/r/#/c/44853/
* https://gerrit.wikimedia.org/r/#/c/44854/

I'd like to avoid such vagueness, especially since the likeliness
increases super-linearly :-/

Given that no one would type those ids by hand anyways—regardless if
they are I+8 or I+40 characters—is there a downside to copy/pasting
I+40 characters vs. I+8 characters?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to