https://bugzilla.wikimedia.org/show_bug.cgi?id=48393
--- Comment #6 from Brad Jorsch <[email protected]> --- (In reply to comment #5) > > So if I understand correctly (and I very well may not), the > Infobox_road/color > Module will not break on enwiki today (because it is Sandbox / Lua-only). Basically yes, since the manner in which it breaks is not accessible. > However, https://gerrit.wikimedia.org/r/#/c/63565/ will force it to break in > the future? (with the goal that Sandbox and Standalone should behave the > same?) Yes, assuming that actually gets merged. In the future it would cause a script error rather than silently breaking, so other situations where the current breakage actually is accessible would generate proper errors. > If so, I'll go to the talk page for Infobox_road/color and recommend a change > based on this ticket. Please do. As I mentioned earlier, the proper fix is to not place that "colors" subtable in the table of functions being returned to PHP for #invoke. Should direct access to that colors table be needed by some other module loading this one with require(), you could split it to a separate module (which could probably be loaded with mw.loadData(), if it's going to be used from many #invoke calls in one page) or you could make an accessor function to return it as needed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
