https://bugzilla.wikimedia.org/show_bug.cgi?id=46615

--- Comment #12 from Tim Starling <[email protected]> ---
(In reply to comment #5)
>(can I +2 a revert if its reverting code I +2'd in the first place)

Yes. I would have preferred it if you had done that instead of leaving the
maintenance script horribly broken for 6 weeks.

(In reply to comment #9)
> Tim wrote the code - can you explain? I suppose loading all the data
> would be slow, but it's not like we're instantiating Collations left
> and right.

In the code I wrote, only uca-default was allowed, and I imagined that there
would be one class per additional locale, so the developer would be required to
check if the relevant locale actually worked before adding a class. You were
the one who added the ability to use any ICU locale, in I838484b9.

Why not call getFirstLetter() from updateCollation.php and see if that throws
an exception?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to