https://bugzilla.wikimedia.org/show_bug.cgi?id=48618
Web browser: ---
Bug ID: 48618
Summary: Store Commons path in a variable in
InitialiseSettings.php
Product: Wikimedia
Version: wmf-deployment
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Site requests
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected]
Classification: Unclassified
Mobile Platform: ---
The text "//upload.wikimedia.org/wikipedia/commons/" in InitialiseSettings.php
is currently duplicated a lot (over 350 times; cf.
<https://noc.wikimedia.org/conf/InitialiseSettings.php.txt>). I'm wondering
whether it makes sense to store this string in a reusable variable (e.g.,
$commonsPath).
Pro: it would reduce the overall file size and make certain sections
(particularly the logo section) easier to read.
Con: it would slightly obfuscate the path to (for example) a logo. Rather than
being a mostly complete string as it is now, it would become "$commonsPath .
/1/d/whatever.png".
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
