https://bugzilla.wikimedia.org/show_bug.cgi?id=48660
Steven Walling <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Steven Walling <[email protected]> --- (In reply to comment #0) > The current implementation of the blocks metric is slightly inconsistent. In > raw requests, the metric returns an array, but the default aggregator > (proportion) operates on the expectation of a boolean. > > I recommend we split blocks into two separate metrics: > > 1) is_blocked (limited to indefinite blocks, always returning a boolean or an > undefined value, and implemented with the same parameters as the threshold > metric, with a default t=24) > > 2) blocks (returning a block count and the associated metadata) > > is_blocked should retain proportion as a default aggregator > > Once this is done, we should also reconsider the best output format for > blocks > as it currently combines in the same array different types (int, timestamp) > and > I am not sure this is the most useful response. The new blocks metric should > return a concise summary of an account's overall blocks history (including > both > temporary and indefinite blocks), the most appropriate aggregator will need > to > be defined accordingly. > > See also BZ ticket #48341 for an issue affecting blocks metric aggregation. This makes sense to me. Looking at indefinite blocks versus current blocks is valid because the purpose of the blocks metric is to tell us how many users in a given cohort were rejected by Wikipedia. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
