https://bugzilla.wikimedia.org/show_bug.cgi?id=47216

--- Comment #6 from Jamie Thingelstad <[email protected]> ---
It looks like this is now being deployed and it's a little odd. Looking at the
diff [1] it's odd to me that unusable flag isn't coming through. It instead
looks like the unusable skins are being omitted which I know was discussed in
Comment 3 above so maybe that was how it was implemented in a later diff.
(Which, by the way, I think is a good way to do it.)

The bigger item is that right now the value for default is '', rather than some
form of boolean. This ends up looking odd, especially in the JSON format.
Perhaps change the output to a boolean value?

http://www.mediawiki.org/w/api.php?action=query&meta=siteinfo&siprop=skins

<?xml version="1.0"?>
<api>
  <query>
    <skins>
      <skin code="cologneblue" xml:space="preserve">CologneBlue</skin>
      <skin code="modern" xml:space="preserve">Modern</skin>
      <skin code="monobook" xml:space="preserve">MonoBook</skin>
      <skin code="vector" default="" xml:space="preserve">Vector</skin>
    </skins>
  </query>
</api>


http://www.mediawiki.org/w/api.php?action=query&meta=siteinfo&siprop=skins&format=json

{"query":
  {"skins":
    [
      {"code":"cologneblue","*":"CologneBlue"},
      {"code":"vector","*":"Vector","default":""},
      {"code":"monobook","*":"MonoBook"},
      {"code":"modern","*":"Modern"}
    ]
  }
}

[1]:
https://gerrit.wikimedia.org/r/#/c/59146/2/includes/api/ApiQuerySiteinfo.php

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to