https://bugzilla.wikimedia.org/show_bug.cgi?id=48949

--- Comment #4 from Arthur Richards <[email protected]> ---
What benefit would we get from merging them? I don't think merging them is a
good idea, though it is possible.

We need to know what problem needs to be solved before we try to solve it, and
it is totally unclear from this bug.

After chatting with MaxSem in e-person I gathered that the concern was that if
a user has the stopMobileRedirect cookie present, but visits a mobile domain,
their requests will always bypass cache (even if they have no other cookies
present). If that was the original impetus for this bug, then the appropriate
thing to do would be to strip the stopMobileRedirect cookie from the headers in
Varnish. However, vcl_recv() in mobile-frontend.inc.vcl.erb makes it looks to
me like this should already be happening:

 55     set req.http.X-Orig-Cookie = req.http.Cookie;
 56     if( req.http.Cookie ~ "disable" ||
 57         req.http.Cookie ~ "optin" ||
 58         req.http.Cookie ~ "session" ||
 59         req.http.Cookie ~ "forceHTTPS" ) {
 60         /* Do nothing; these are the cookies we pass.
 61          * this is a hack in the absence of X-V-O support
 62          */
 63     } else {
 64         unset req.http.Cookie;
 65     }

Anyway, I think a new bug should be opened by someone with information about
the actual problem and we should act on that rather than trying to guess.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to