https://bugzilla.wikimedia.org/show_bug.cgi?id=48450
Antoine "hashar" Musso <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #5 from Antoine "hashar" Musso <[email protected]> --- We had that debate at the beginning of 2013. When type casting, do not use a space after the cast: (int)$foo; http://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions/PHP&diff=652478&oldid=648613 Later improved with code to not use (aka anything with spaces): ( int )$bar; ( int ) $bar; ( int ) $bar; http://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions/PHP&diff=674672&oldid=673901 Using the standard from mediawiki/tools/codesniffer.git at commit e1de64e4 , PHPCs processing gives out: (int)$foo; // A cast statement must be followed by a single space ( int )$bar; // A cast statement must be followed by a single space ( int ) $bar; // considered valid, should not ( int ) $bar; // considered valid, should not That is happening since https://gerrit.wikimedia.org/r/#/c/58637/ which did the following change: - <rule ref="Generic.Formatting.NoSpaceAfterCast" /> + <rule ref="Generic.Formatting.SpaceAfterCast" /> We need to revert it again, aka like what I did in https://gerrit.wikimedia.org/r/#/c/45142/ : - <rule ref="Generic.Formatting.SpaceAfterCast" /> + <rule ref="Generic.Formatting.NoSpaceAfterCast" /> -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
