https://bugzilla.wikimedia.org/show_bug.cgi?id=49228
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|edit warning feature lost |Vector: The version of the |in mw1.21 |Vector extension bundled | |with MediaWiki 1.21 is | |incompatible --- Comment #12 from Krinkle <[email protected]> --- The reason the MediaWiki 1.21 release with the bundled version of Vector is incompatible is because Mark accidentally bundled the lastest master of each extension instead of the (at that point in time, not yet created) REL1_21 branch. As a result, developments that happened in the Vector extension after the 1.21 branch point that rely on 1.22 developments, are broken. Timeline: * mediawiki/core mediawiki/extensions/Vector * REL1_21 created * - <version 1.21.0> * master (1.22-alpha) * - add editWarning.js - remove editWarning.js * <version bundled in 1.21.0> The MediaWiki 1.21.0 bundle contains core from before the move and extensions/Vector from after the move. So the bundle doesn't have either version, it is missing in both. Though this particular incompatibility is harder to detect, there an infinite number of ways extensions can become incompatible with core when taken from different points in core. Whenever core changes, extensions usually follow soon after. Especially if the change is backwards incompatible. This was to be expected, of course, and is hopefully a sign that next time "quick testing" to make sure it all works is not going to be acceptable. Releases must bundle the appropriate versions of extensions regardless of whether or not the latest version seems to work. Release branches in extension repositories need to be created from the right timestamp. If you want certain newer developments to land in the release bundle they'll have to be back ported like we do for everything else by cherry-picking them onto the release branch from master and through Gerrit review. Now for the current situation, the release has already been made so we can't go back on this one. The simplest course of action is to revert the 1.21-incompatible commit from 1.22-master in REL1_21 branch. That will (hopefully) resolve the specific problem raised by this bug. However I don't think we should do that. I'd recommend we reset (by deleting and re-creating) the REL1_21 branches to where they should've been created by the make-extension-branches script. In other words, undo the exceptions we made in bug 48837. Not just for the Vector extension but for all bundled extensions, because no doubt there are other non-obvious incompatibilities released as a result of this. I can easily do this in a few minutes. This would solve any and all incompatibilities (including the problem reported in this bug) @Mark: Regardless of which action we take, can we actually release patches to bundled extensions? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
