https://bugzilla.wikimedia.org/show_bug.cgi?id=49391

       Web browser: ---
            Bug ID: 49391
           Summary: FSFileBackend doPrepareInternal() should recover from
                    mkdir failure when directory exists  (race)
           Product: MediaWiki
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: File management
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected]
    Classification: Unclassified
   Mobile Platform: ---

Browsers doing multiple http requests at once for items linked to (thumbs) in a
file description page are going to set off the race condition from time to time
in FSFBackend:

if ( !wfMkdirParents( $dir ) ) { // make directory and its parents
     $status->fatal( 'directorycreateerror', $params['dir'] ); // fails on
races

Why not check if the error was 'File exists' and proceed in that case?  The
debug log entry looks like this:
[FSFileBackend] mkdir() [<a href='function.mkdir'>function.mkdir</a>]: File
exists
If the status object doesn't have a good representation of the type of error
condition, you could always double check if the dir is suddenly there before
giving up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to