https://bugzilla.wikimedia.org/show_bug.cgi?id=49397
--- Comment #1 from MWJames <[email protected]> --- Thanks for your report. Generally it would be better to provide a Gerrit patch as it will accelerate the review process and help to resolve the issue as quick as possible. PS: The attached file (SMW_DV_Number) was not based on the current master making it difficult for a reviewer to come to an assertion but a quick diff analysis showed that the only thing that changed was: - $parts = preg_split( '/([-+]?\s*\d+(?:\\' . $kiloseparator . '\d\d\d)*' . + $parts = preg_split( '/([-+]?\s*(?:\d+(?:\\' . $kiloseparator . '\d{3})*)?' . PSS: Changes like this need to be verified using a unit test (small changes like this are critical as they can have a lasting impact on the data conversion) in order to ensure that for a range of conditions results are as expected. I don't have time to write a unit test for this to verify its validity and I assume Jeroen will be busy meaning it can take some time before this change will be merged unless a unit test is provided. Again, thanks for your effort. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
