https://bugzilla.wikimedia.org/show_bug.cgi?id=49504
Web browser: ---
Bug ID: 49504
Summary: ipb_range_start and ipb_range_end should be blank for
single-IP blocks
Product: MediaWiki
Version: 1.22-git
Hardware: All
OS: All
Status: NEW
Keywords: performance, platformeng
Severity: normal
Priority: Unprioritized
Component: User blocking
Assignee: [email protected]
Reporter: [email protected]
Classification: Unclassified
Mobile Platform: ---
When ipb_range_start and ipb_range_end were introduced in r11887, they were set
to an empty string for single-IP blocks. Identifying ranges which contain a
given IP requires scanning, so removing single-IP blocks from the part of the
index inhabited by range blocks reduced the amount of scanning which needed to
occur.
This was accidentally broken in r17865/r17866, where a call to
wfRangeStartEnd(), which rejected single IPs, was replaced with
IP::parseRange(), which accepts single IPs.
We now have about 80,000 single-IP blocks on en.wp. 13,000 of them still have
an empty ipb_range_start, presumably created before r17866 (all have infinite
expiry). The amount of table scanning is proportional to the number of blocks
in the user's /16 range: 18 /16 ranges have more than 500 blocks, 61 have more
than 100 blocks. The problem may well get worse as IPv6 becomes more common:
the IPv6 code also uses a /16 division of index space.
ApiQueryBlocks now depends on the fact that ipb_range_start is populated, and
so won't correctly display the 13,000 old blocks. Possibly there is other code
that makes the same assumption. Such code should be fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
