https://bugzilla.wikimedia.org/show_bug.cgi?id=17297
--- Comment #20 from Philippe Verdy <[email protected]> --- Apparently you have abandonned it because of the code review comment sent which says: Patch Set 1: There's a problem with this change, please improve Unit-less line-height is good. However removing them from existing styles as-is is likely to cause layout problems. In this change I only see straight removals, which I suspect has unintended visible influence. Previously they were accumulative (an em line-height on p, affected by em line-height of #content, affected by em line-height of html/body. Preliminary -1 for caution and suspicion. Will check out soon (or someone else feel free to ignore this vote if you're certain). But this comment is incorrect. ine-heights are not comulative when a unit-lesss line-height is specified in p, #content, html, body: the inheritance stops there on each new subelement : in addition, theses are ALL block elements, only the innermost block element will specify the line-height for its inline subelements. So a paragraph can be styled with "line-height:1.5" and this will work when inner spans secify a bigger font. And you ''may' use units, only in "em" or "ex", for sub and sup elements if you want to preserve even lines in the paragraph (line-height:1em works for sub/sub, except when these subelements also contain big/small subelements on subscripts/superscripts with long, breakable contents spanning several lines (such as calls to footnotes using several words lie "Note 1" instead of "[1]", using <ref group="Note">...</ref>). But even in the case of superscripts/subscripts, you should also use unitless values for them, it you want even lines for the whole paragraph containing syperscripts/subscripts. Note that changng the line-height on superscripts/subscripts does not work very well with some languages/scripts, such as Khmer or Tibetan. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
