https://bugzilla.wikimedia.org/show_bug.cgi?id=49722

--- Comment #2 from Krinkle <[email protected]> ---
We didn't pass this to the client and on to load.php because printable pages
shouldn't run run any load queue.

http://mediawiki.dev/?printable=yes gives me:
> #top:
> mw.loader.load(["mediawiki.page.startup","mediawiki.legacy.wikibits","mediawiki.legacy.ajax"]);
> #bottom:
> mw.loader.load(["mediawiki.action.view.postEdit","mediawiki.user","mediawiki.hidpi","mediawiki.page.ready","mediawiki.searchSuggest","mediawiki.page.watch.ajax","ext.vector.collapsibleNav","ext.vector.collapsibleTabs","ext.visualEditor.viewPageTarget","skins.vector.js"],null,true);


Which is wrong, those things are not supposed to be loaded on a print page (to
avoid e.g. collapsible buttons, "[show]", etc.). Though some of those are
hidden by CSS, it'd be better for them to not initialise in the first place.

I think this is a regression. If memory serves, not so long ago there were no
mw.loader calls on the printable view. Perhaps a change in Skin caused them to
be inserted unconditionally?

Either way, if there is no other way around it, then the proposed change is
good, but I'd prefer to prevent the client-side loader from being set up in the
first place (so only the <link only=styles> will run).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to