https://bugzilla.wikimedia.org/show_bug.cgi?id=49876
--- Comment #1 from Ċ½eljko Filipin <[email protected]> --- Cucumber step definitions[1] should be sorted alphabetically. This is how a definition looks like: step_type(/^step name$/) do # ruby code end Example (from visual_editor_steps.rb[2]): Given(/^I am at my user page$/) do visit(VisualEditorPage) end When /^I click Save page$/ do on(VisualEditorPage).save_page_element.click end Then /^Page text should contain the string$/ do @browser.text.should match Regexp.escape("Editing with #{@does_not_exist_page_name}") end Ruby code should be ignored. Steps should be grouped by type. "Given" steps should be grouped together, the same for "When" and "Then" steps. Inside the group, steps should be sorted alphabetically by step name. For a good example on how steps should be grouped and sorted see aftv5_steps.rb[3] file. 1: https://github.com/wikimedia/qa-browsertests/tree/master/features/step_definitions 2: https://github.com/wikimedia/qa-browsertests/blob/master/features/step_definitions/visual_editor_steps.rb 3: https://github.com/wikimedia/qa-browsertests/blob/master/features/step_definitions/aftv5_steps.rb -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
