https://bugzilla.wikimedia.org/show_bug.cgi?id=4801


Ilmari Karonen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor




--- Comment #7 from Ilmari Karonen <[email protected]>  2009-09-20 17:06:34 UTC 
---
The recent breakage of user JS preview on the MonoBook skin appears to be a
regression caused by r53282: specifically, the function setupSkinUserJs()
that's supposed to add the scripts to the page is never actually called.  As
for the Vector skin, it looks like the feature was never there to begin with. 
As for the other skins... I've no idea.  The whole skin system is a total mess
anyway. :(

Anyway, it actually still works on my local wiki's custom skin, which I forked
from MonoBook back in February 2008.  So most of the code is clearly still
working, it's just the skin-specific parts that are broken.

Oh, and the "expected behaviour" suggested by Helder above is actually a
feature request, or perhaps a request to _remove_ a feature.  The intended
behavior when previewing user JS/CSS files is to embed the script or stylesheet
on the preview page, in effect previewing its effects rather than its source
code (which can be seen in the edit box anyway).  That said, it might indeed be
a good idea to make it do both (or perhaps even to separate the functions,
introducing a new submit button labeled something like "Test script" or "Test
stylesheet").

I'd do it if I didn't have a headache already.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to