https://bugzilla.wikimedia.org/show_bug.cgi?id=50112

       Web browser: ---
            Bug ID: 50112
           Summary: Zuul: project-templates override defined project jobs
           Product: Wikimedia
           Version: wmf-deployment
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Continuous integration
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected],
                    [email protected]
    Classification: Unclassified
   Mobile Platform: ---

The project-template feature I wrote is bugged. It was supposed to merge
defined jobs with the one defined by a template but it is overwriting them:

Example:

  - name: mediawiki/tools/release
    check-voter:
      - mw-tools-release-phplint
    template:
      - name: 'python-lint'
        prefix: 'mw-tools-release'

That will only generate the jobs from the template and discard the phplint job.

The root cause is in Zuul scheduler:

  # Finally merge the expansion with whatever has been already
  # defined for this project
  config_project.update(expanded)

dict.update() does not do a recursive merge. We need a new function that will
recursively merge all values being dicts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to