https://bugzilla.wikimedia.org/show_bug.cgi?id=46483
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Install voting sniff to |Jenkins: Create |ensure dataProvider as |PHP_CodeSniffer sniff to |public static |ensure test functions have | |the proper signature --- Comment #2 from Krinkle <[email protected]> --- The sniff should assert: * setUp/tearDown is "protected static function" * test function is "public function" * dataProvider is "public static function" And maybe: * setUp/tearDown should call parent method (not sure about the latter, I think there are some cases were we genuinely don't) -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
