https://bugzilla.wikimedia.org/show_bug.cgi?id=50193
Web browser: ---
Bug ID: 50193
Summary: bug in collapsibleTabs that causes exception: null !=
nudefined
Product: MediaWiki
Version: 1.22-git
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: Unprioritized
Component: JavaScript
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
so, in 1.22wmf8, there is a new collapsibleTabs.js (
https://bits.wikimedia.org/static-1.22wmf8/skins/vector/collapsibleTabs.js
)
in line 85 we ask "if ( $settings !== null )".
clearly, this is the wrong question. maybe
if ( typeof($settings) === "object" )
will work better.
as it is, when there is no data, "$setting" is undefined, and the test
$setting != null
returns true, because "null" and "undefined" are two different things.
this cause many things to fail, and in particular, unregistered users lose the
"history" tab if they have JS enabled.
peace.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
