https://bugzilla.wikimedia.org/show_bug.cgi?id=50204

--- Comment #4 from [email protected] ---
GettingStarted only logs page-save-success if wgPostEdit is true. On my local
wiki I printed log messages from the two routines, and they sometimes came out:
   about to log returnto page-impression
   postEdit.js set wgPostEdit true!

So the postEdit.js is running *after* openTask.js and that's why the wrong
event is logged. On enwiki with resourceLoaderDebug cookie it did log a
page-save-success event (go look at GettingStartedNavbar_5588671 where
event_userId = 19275523), but without the RL debug in regular operation GS logs
page-impression.

RL loads postEdit first in its mw.loader.load() call at the end of the page
body, but I don't know what RL's guarantee of code execution ordering is.

Adding a dependency to ext.gettingstarted.openTask:
        'mediawiki.action.view.postEdit', // need this to run prior

seemed to fix it locally; another fix would be to use 
        mw.hook( 'postEdit' ).add( function ()
as VE does instead of changing the action from page-impression to
page-save-success.

I don't know how VE affects this, this was all clicking [Edit source].

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to