https://bugzilla.wikimedia.org/show_bug.cgi?id=49699
--- Comment #4 from James Forrester <[email protected]> --- (In reply to comment #2) > Just as an addition to this: I'm not sure if just the checkbox is what is > needed. The current work flow has a whole separate page because we need to > show the diff involved for the review. I imagine that can be done without > going to a new page but either way they should be able to review the diff > (and preferably leave a comment like you can in the review page now) before > checking any kind of approve box since they become somewhat responsible for > those edits. Yes, indeed; I was imagining: * on load, an alert in the edit notices saying "You will need to accept the outstanding changes before saving" (or whatever the current message is) - possibly with a link to the below? * on entering the save dialog, the save button will be disabled with another copy of the "You will need to accept the outstanding changes before saving" text (in the same place as the edit conflict / CAPTCHA / DOM corruption warnings) * in the line of buttons ("Save page", "Review your changes") there should be a third button, "Review outstanding changes", which on click pops up the diff of outstanding changes, with a text box for the optional review comment and an "accept these changes" button that takes you back to the save dialog, now with the save button enabled. Feels a little clunky, though - perhaps we could make the process in-line with the edit summary message? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
