https://bugzilla.wikimedia.org/show_bug.cgi?id=51156
Web browser: ---
Bug ID: 51156
Summary: ParsoidCacheUpdateJob queues htmlCacheUpdate jobs on
template edits
Product: Parsoid
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: Unprioritized
Component: General
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected]
Classification: Unclassified
Mobile Platform: ---
Every edit results in a ParsoidCacheUpdateJob. Every time a template is edited
which has more than 20 pages that use it, ParsoidCacheUpdateJob purges the
cache of those pages by queueing htmlCacheUpdate jobs.
This is because ParsoidCacheUpdateJob extends from HTMLCacheUpdateJob. It calls
doFullUpdate(), which is not overridden, which calls insertPartitionJobs(),
which is also not overridden, which inserts the relevant htmlCacheUpdate jobs.
I've confirmed this with strace/eval.php in production.
HTMLCacheUpdateJob was not intended for subclassing. Trying to override almost
every method of a class in order to use the remaining behaviour is error-prone.
I think you should either derive directly from Job (with some duplication), or
factor out an abstract base class which would be common to both
HTMLCacheUpdateJob and ParsoidCacheUpdateJob.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
