https://bugzilla.wikimedia.org/show_bug.cgi?id=51155

Brad Jorsch <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |easy
                 CC|                            |[email protected]
            Summary|Add rvparsepst= and maybe   |Add option to
                   |rvparseonlypst= to          |ApiQueryRevisions to do the
                   |ApiQueryRevisions           |pre-save transform on
                   |                            |rvdifftotext before diffing

--- Comment #1 from Brad Jorsch <[email protected]> ---
As stated, this request doesn't make any sense. The content being parsed by
rvparse is what is already saved in the database, so it has already had the
pre-save transform done on it before it was saved (hence the name "pre-save
transform"). There's no reason to do the PST on it again.

But it seems like what you really want is an option to perform the PST on the
text passed to rvdifftotext before doing the diff, which could make a sort of
sense. But the option shouldn't be named "rvparsepst" or "rvparseonlypst", it
should be named something like "rvdifftotextpst" to associate it with what it
applies to. I've taken the liberty of changing the bug title accordingly; if
you disagree, feel free to revert and we'll go from there.

Actually doing the PST then should be easy enough, you just need to call
$difftocontent->preSaveTransform( ... ) in between creating $difftocontent and
handing it off to the difference engine. All this is currently around line 600
of ApiQueryRevisions.php.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to