https://bugzilla.wikimedia.org/show_bug.cgi?id=51465
Jon <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #4 from Jon <[email protected]> --- Just to check I understand the problem correctly: You want to show a banner on the desktop site (en.wikipedia.org and friends) when viewed in a mobile phone? Was there any reason you didn't do this before? I don't really understand the logic... ResourceLoader disables JavaScript on older phones so these banners should work perfectly fine. Could you clarify "Removing the filtering comes at the expense of potentially exposing users to banners that don't work particularly well on small screens." - if a mobile views the desktop site on their phone they will either use a modified viewport [1] and the banner will look exactly the same as desktop, or if there is no viewport the entire website will be unreadable so I'd be surprised they'd even be in desktop mode. Does this effect the mobile site (en.m.wikipedia.org and friends) in anyway? I'm also unclear how this effects the VisualEditor roll out... (you mention this in the CentralNotice fix). The stopMobileRedirect cookie exists for a reason - if a user of the mobile site wants to see the desktop site this stops them from being redirected on every visit. We could only set the stopMobileRedirect cookie if the user is on a mobile phone but this is messy and I don't see what value the work put in to achieve this would gain. Does anything really need to change in MobileFrontend now? [1] http://www.quirksmode.org/mobile/viewports2.html -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
